Skip to content

Conversation

@rvandernoort
Copy link
Contributor

@rvandernoort rvandernoort commented Oct 16, 2025

What this PR does / why we need it

extraContainers:
  - name: hello-world
    image: busybox:latest
    command: ["sh", "-c", "while true; do echo Hello World; sleep 10; done"]

results in

    containers:
        - name: prometheus-stackdriver-exporter
          image: "prometheuscommunity/stackdriver-exporter:v0.18.0"
          imagePullPolicy: IfNotPresent
          command: ["stackdriver_exporter"]
          volumeMounts:
          args:
            - --google.project-ids=someid
            - --monitoring.metrics-interval=5m
            - --monitoring.metrics-offset=0s
            - --monitoring.metrics-prefixes=somemetric
            - --stackdriver.backoff-jitter=1s
            - --stackdriver.http-timeout=10s
            - --stackdriver.max-backoff=5s
            - --stackdriver.max-retries=0
            - --stackdriver.retry-statuses=503
            - --web.listen-address=:9255
            - --web.telemetry-path=/metrics
            - --web.stackdriver-telemetry-path=/metrics
          resources:
            {}
          ports:
            - containerPort: 9255
              name: http
          livenessProbe:
            httpGet:
              path: /
              port: http
              scheme: HTTP
            initialDelaySeconds: 30
            timeoutSeconds: 10
          readinessProbe:
            httpGet:
              path: /
              port: http
              scheme: HTTP
            initialDelaySeconds: 10
            timeoutSeconds: 10
      - command:
        - sh
        - -c
        - while true; do echo Hello World; sleep 10; done
        image: busybox:latest
        name: hello-world

but this should be

    containers:
        - name: prometheus-stackdriver-exporter
          image: "prometheuscommunity/stackdriver-exporter:v0.18.0"
          imagePullPolicy: IfNotPresent
          command: ["stackdriver_exporter"]
          volumeMounts:
          args:
            - --google.project-ids=someid
            - --monitoring.metrics-interval=5m
            - --monitoring.metrics-offset=0s
            - --monitoring.metrics-prefixes=somemetric
            - --stackdriver.backoff-jitter=1s
            - --stackdriver.http-timeout=10s
            - --stackdriver.max-backoff=5s
            - --stackdriver.max-retries=0
            - --stackdriver.retry-statuses=503
            - --web.listen-address=:9255
            - --web.telemetry-path=/metrics
            - --web.stackdriver-telemetry-path=/metrics
          resources:
            {}
          ports:
            - containerPort: 9255
              name: http
          livenessProbe:
            httpGet:
              path: /
              port: http
              scheme: HTTP
            initialDelaySeconds: 30
            timeoutSeconds: 10
          readinessProbe:
            httpGet:
              path: /
              port: http
              scheme: HTTP
            initialDelaySeconds: 10
            timeoutSeconds: 10
        - command:
          - sh
          - -c
          - while true; do echo Hello World; sleep 10; done
          image: busybox:latest
          name: hello-world

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@rvandernoort rvandernoort requested a review from rpahli as a code owner October 16, 2025 07:55
@rpahli rpahli merged commit f1dad2b into prometheus-community:main Oct 20, 2025
6 checks passed
@rvandernoort rvandernoort deleted the patch/extracontainer-stackdriver branch October 21, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants